XSite
  1. XSite
  2. XSITE-52

Remove non-generic stuff in the PicoXSiteFactory confoguration and FreemarkerSkin

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.3
    • Fix Version/s: 1.3
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      XSite registers for the PicoXSiteFactory the non-generic TagRule AddFirstChildClassToHeader in the PicoXSiteFactory, that adds a class tag with the value FirstChild to the first header element.

      The FreemarkerSkin implementation adds a property centerClass to its page context with value Content3Column if it is the index page and otherwise with the value Content2Column.

      Both behaviors are specific to a special HTML skin used in the example and do not really belong into core. The example's skin has to be updated with Freemarker's own functionality for the 3-column-design on the index page.

        Activity

        Hide
        Jörg Schaible added a comment -

        Fixed in trunk

        Show
        Jörg Schaible added a comment - Fixed in trunk
        Jörg Schaible made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jörg Schaible
            Reporter:
            Jörg Schaible
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: