XSite
  1. XSite
  2. XSITE-49

Allow DI to instantiate TagRules using a PageBuilder

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.3
    • Fix Version/s: 1.3
    • Component/s: Core
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Dependency injection can be used currently to create only TagRule instances that are not using a PageBuilder. However, most provided implementations of SiteMesh require such an instance and functionally empowered rules will have to use one. Current SiteMeshPageExtractor is using such an instance of an anonymous class internally for own registered rules.

      The anonymous class has to be made explicit as AttributedPageBuilder (a derived PageBuilder from SiteMesh, but with property support) and the SiteMeshPageExtractor implementation must support constructors taking such an AttributedPageBuilder instance provided by DI. That instance is then also available for any TagRule registered in the DI container.

        Issue Links

          Activity

          Jörg Schaible made changes -
          Field Original Value New Value
          Link This issue is depended upon by XSITE-55 [ XSITE-55 ]
          Hide
          Jörg Schaible added a comment -

          Fixed in trunk

          Show
          Jörg Schaible added a comment - Fixed in trunk
          Jörg Schaible made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Jörg Schaible
              Reporter:
              Jörg Schaible
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: