Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Not A Bug
-
Affects Version/s: 1.4.2
-
Fix Version/s: 1.x Maintenance
-
Component/s: Converters
-
Labels:None
Description
<myInstrument>
<myInstrumentId>20</paymentInstrumentId>
<nickName>XYZ</nickName>
<defaultInstrument/>
</myInstrument>
I have define the data type for defaultInstrument to be Boolean. And I expect this value to be null if nothing is passed in the request so that I don't end up updating the already stored default value of this instrument. I looked into the BooleanConvertor code.
public Object fromString(final String str) {
if (caseSensitive)
else
{ return positive.equalsIgnoreCase(str) ? Boolean.TRUE : Boolean.FALSE; }}
There is no check if its primitive type or an Object and to take a decision that value can be null for the object. Is there a way to handle this wo\ithout having to right a custom converter.
Activity
I'm using Spring to send an XML request with empty tag. Xtream Marshaller is getting used to marshall the values. My model class has
Boolean defaultInstrument
The xml request has the empty tag
<defaultInstrument/>
When this gets marshalled the value is "false", however it should be null because the datatype is Boolean and not boolean. Is there anything else that I need to specify so that the check for primitive and Object datatypes are taken care of.
Abhay Kumar
added a comment - I'm using Spring to send an XML request with empty tag. Xtream Marshaller is getting used to marshall the values. My model class has
Boolean defaultInstrument
The xml request has the empty tag
<defaultInstrument/>
When this gets marshalled the value is "false", however it should be null because the datatype is Boolean and not boolean. Is there anything else that I need to specify so that the check for primitive and Object datatypes are taken care of. I have checked the value of str in the method
public Object fromString(final String str)
its "" and not null. So there is no value present for this tag. Is there a way to specify if the tag has no value ignore it while Marshalling into an object.
Abhay Kumar
added a comment - I have checked the value of str in the method
public Object fromString(final String str)
its "" and not null. So there is no value present for this tag. Is there a way to specify if the tag has no value ignore it while Marshalling into an object.
I have checked the value of str in the method
public Object fromString(final String str)
its "" and not null. So there is no value present for this tag. Is there a way to specify if the tag has no value ignore it while Marshalling into an object.
Abhay Kumar
added a comment - I have checked the value of str in the method
public Object fromString(final String str)
its "" and not null. So there is no value present for this tag. Is there a way to specify if the tag has no value ignore it while Marshalling into an object. Read the code of the converter again! It checks only for the positive value, so anything else will result in Boolean.FALSE. You're probably using an outdated version of XStream?
Jörg Schaible
added a comment - Read the code of the converter again! It checks only for the positive value, so anything else will result in Boolean.FALSE. You're probably using an outdated version of XStream? Yes it checks only for Positive value. I'm using 1.4.2. The class comment says
- Converts a boolean primitive or java.lang.Boolean wrapper to a String.
So I was thinking there might be way to specify that if the value that is received in "" it should be treated as null.
Abhay Kumar
added a comment - Yes it checks only for Positive value. I'm using 1.4.2. The class comment says
Converts a boolean primitive or java.lang.Boolean wrapper to a String.
So I was thinking there might be way to specify that if the value that is received in "" it should be treated as null. 
The converter cannot receive null, therefore no such check is required.