Details
Bug
Closed
Major
Description
With issue XSTR-473 the validation of characters for XML 1.0 has been introduced. This works fine for most of the charcters that are not allowed in XML, but it does not work for the characters in the range #x10 and #x1F, which are not allowed as well refering to the XML spec:
#x9 | #xA | #xD | x20-#xD7FF | xE000-#xFFFD | x10000-#x10FFFF
Activity
JUnit test cases for the characters that are not checked.
Show
Boon Elschenbroich
added a comment - JUnit test cases for the characters that are not checked.
Boon Elschenbroich
added a comment - JUnit test cases for the characters that are not checked. Hi Joerg,
from my point of view the PrettyPrintWriter writeText should contain the check for the characters in question, like:
if (mode == XML_1_0) { if (c < 9 || c == '\u000b' || c == '\u000c' || c == '\u000e' || c == '\u000f' || (c >= '\u0010' && c <= '\u001F')) { // additional check for XSTR-684 throw new StreamException("Invalid character 0x" + Integer.toHexString(c) + " in XML 1.0 stream"); } }
Show
Boon Elschenbroich
added a comment - - edited Hi Joerg,
from my point of view the PrettyPrintWriter writeText should contain the check for the characters in question, like:
if (mode == XML_1_0) {
if (c < 9
|| c == '\u000b'
|| c == '\u000c'
|| c == '\u000e'
|| c == '\u000f'
|| (c >= '\u0010' && c <= '\u001F')) { // additional check for XSTR-684
throw new StreamException( "Invalid character 0x"
+ Integer .toHexString(c)
+ " in XML 1.0 stream" );
}
}
Boon Elschenbroich
added a comment - - edited Hi Joerg,
from my point of view the PrettyPrintWriter writeText should contain the check for the characters in question, like:
if (mode == XML_1_0) {
if (c < 9
|| c == '\u000b'
|| c == '\u000c'
|| c == '\u000e'
|| c == '\u000f'
|| (c >= '\u0010' && c <= '\u001F')) { // additional check for XSTR-684
throw new StreamException( "Invalid character 0x"
+ Integer .toHexString(c)
+ " in XML 1.0 stream" );
}
}
Fixed in head. Thanks for heads-up.
Show
Jörg Schaible
added a comment - Fixed in head. Thanks for heads-up.
Jörg Schaible
added a comment - Fixed in head. Thanks for heads-up. 
Can you provide a test case please?