Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Cannot Reproduce
-
Affects Version/s: 1.3
-
Fix Version/s: None
-
Component/s: Converters
-
Labels:None
Description
Here's a unit test. It fails with the first two of the 5 parameters. I think this is probably a bug in the SimpleDateFormat and/or GregorianCalendar, but you can probably fix it by choosing a time zone and sticking to it when you convert to/from XML.
Activity
Hi Dave,
I am not familiar with JUnit 4.x and XStream code base is largely JDK 1.3 compatible, so bear with me ... can you provide a test for JUnit 3 as attachment? This saves my time a lot and especially regarding Date/TimeZone problems I must be absolutely sure, how anything is initialized - it's quite tricky, since the JDKs behave also different.
- Jörg
Jörg Schaible
added a comment - Hi Dave,
I am not familiar with JUnit 4.x and XStream code base is largely JDK 1.3 compatible, so bear with me ... can you provide a test for JUnit 3 as attachment? This saves my time a lot and especially regarding Date/TimeZone problems I must be absolutely sure, how anything is initialized - it's quite tricky, since the JDKs behave also different.
Jörg
Dave,
I've added a unit test to XStream for those dates, but it works as expected. Remember, that the XStream DateConverter will use for its own formatters always the current default time zone. Since this is highly dependent on the TZ info provided with the individual Java version, all I can say that I currently run JDK 1.5.0_16 on Linux.
- Jörg
Jörg Schaible
added a comment - Dave,
I've added a unit test to XStream for those dates, but it works as expected. Remember, that the XStream DateConverter will use for its own formatters always the current default time zone. Since this is highly dependent on the TZ info provided with the individual Java version, all I can say that I currently run JDK 1.5.0_16 on Linux.
Jörg
Closed after receiving no further comment.
Jörg Schaible
added a comment - Closed after receiving no further comment. 
@RunWith(Parameterized.class)
public class DateFormatTests {
private static final String pattern = "yyyy-MM-dd HH:mm:ss.S z";
final private String input;
final private SimpleDateFormat format;
private XStream xstream = new XStream();
public DateFormatTests(String input)
{ this.format = new SimpleDateFormat(pattern, Locale.UK); format.setTimeZone(TimeZone.getTimeZone("GMT")); this.input = input; }@Test
{ Date date = format.parse(input); String xml = xstream.toXML(date); Date output = (Date) xstream.fromXML(xml); System.err.println(xml + " : " + format.format(output)); assertTrue(xml.contains(input)); }public void testDateFormat() throws Exception
@Parameters
public static List<Object[]> data() {
List<Object[]> params = new ArrayList<Object[]>();
{ "1970-01-01 11:20:34.0 GMT"}// First two fail (in GMT timezone)...
params.add(new Object[]
);
{ "1971-01-01 11:20:34.0 GMT"}params.add(new Object[]
);
{ "1972-01-01 11:20:34.0 GMT"}params.add(new Object[]
);
{ "1973-01-01 11:20:34.0 GMT"}params.add(new Object[]
);
{ "1974-01-01 11:20:34.0 GMT"}params.add(new Object[]
);
return params;
}
}