Details
-
Type:
New Feature
-
Status:
Closed
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.2
-
Component/s: None
-
Labels:None
Description
ConventionalStringConverter is a converter that assumes two things about the class that is passed into its ctor ..
1) There is a single string parameter for the constructor of the class that its helping
2) toString() does something meaningful on the same class.
Like so ...
public class Foo {
private foo;
public Foo(String foo)
public String toString()
{ return foo; }}
Activity
Or better yet SingleStringConstructableConverter?
Mauro Talevi
added a comment - Or better yet SingleStringConstructableConverter? ToStringConverter ?
Jörg Schaible
added a comment - ToStringConverter ? This is why I reply on brighter collaborators to name/rename things ... after committing 
Paul Hammant
added a comment - This is why I reply on brighter collaborators to name/rename things ... after committing Of course, String itself matches the ToString ideal.
Thus ...
xStream.useAttributeFor( ... , String.class);
xStream.registerConverter(new ConventionalStringConverter(String.class));
could be replaced with ...
xStream.useAttributeFor( ... , String.class);
as long as 'useAttributeFor' performs a silent ...
xStream.registerConverter(new ConventionalStringConverter(String.class));
Paul Hammant
added a comment - Of course, String itself matches the ToString ideal.
Thus ...
xStream.useAttributeFor( ... , String.class);
xStream.registerConverter(new ConventionalStringConverter(String.class));
could be replaced with ...
xStream.useAttributeFor( ... , String.class);
as long as 'useAttributeFor' performs a silent ...
xStream.registerConverter(new ConventionalStringConverter(String.class));
Applied, using ToStringConverter as name.
Mauro Talevi
added a comment - Applied, using ToStringConverter as name. 
How about renaming it StringConstructableConverter?