Details
-
Type:
Improvement
-
Status:
Closed
-
Resolution: Won't Fix
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
Please refactor StaxDriver to simplify customization of the factories. I suggest the attached patch.
Issue Links
Activity
After fixing XSTR-302 and applying your patch from XSTR-304, it seems to me that this change would be now some kind of over-refactoring. The two methods getInputFactory and getOutputFactory are explicitly there to be overloaded. So I see personally no value in refactoring the call to newInstance() out again. Please reopen, if you feel that I might have missed a point.
Show
Jörg Schaible
added a comment - After fixing XSTR-302 and applying your patch from XSTR-304 , it seems to me that this change would be now some kind of over-refactoring. The two methods getInputFactory and getOutputFactory are explicitly there to be overloaded. So I see personally no value in refactoring the call to newInstance() out again. Please reopen, if you feel that I might have missed a point.
Jörg Schaible
added a comment - After fixing XSTR-302 and applying your patch from XSTR-304 , it seems to me that this change would be now some kind of over-refactoring. The two methods getInputFactory and getOutputFactory are explicitly there to be overloaded. So I see personally no value in refactoring the call to newInstance() out again. Please reopen, if you feel that I might have missed a point. Closing after receiving no further comment.
Show
Jörg Schaible
added a comment - Closing after receiving no further comment.
Jörg Schaible
added a comment - Closing after receiving no further comment. 
Attached find a sample customization (StaxUtilsDriver).