Details
-
Type:
New Feature
-
Status:
Closed
-
Resolution: Won't Fix
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
In the following case I might want to have a converter for base, that is also used when I serialize derived.
class base
{
String it
}
class derived extends base
{
String second
}
The base converted might place its members in attributes, while derived (via standard marshaling) will place it in elements:
<derived it="dd">
<second>bla</string>
</derived>
Activity
No, the point is, that the derived class has additional fields. A normal custom converter for "base", will not take that into account. Michael does not want to repeat in his converter the fields inherited from the base. OTOH he could just derive the converter for "derived" from hte one form "base" and call super.marshall(..).
Jörg Schaible
added a comment - No, the point is, that the derived class has additional fields. A normal custom converter for "base", will not take that into account. Michael does not want to repeat in his converter the fields inherited from the base. OTOH he could just derive the converter for "derived" from hte one form "base" and call super.marshall(..). Got it... favoring composition:
class DerivedConverter implements Converter {
private BaseConverter base = new BaseConverter();
marshall(args)
{ base.marshall(args); // derived changes }unmarshall(args)
{ base.unmarshall(args); // derived changes }canConvert(Class type)
{ return type.equals(Derived.class); }}
Guilherme Silveira
added a comment - Got it... favoring composition:
class DerivedConverter implements Converter {
private BaseConverter base = new BaseConverter();
marshall(args)
{
base.marshall(args);
// derived changes
}
unmarshall(args)
{
base.unmarshall(args);
// derived changes
}
canConvert(Class type)
{
return type.equals(Derived.class);
}
} Composition will cover this use case. If you have additional needs, please re-open the issue.
Jörg Schaible
added a comment - Composition will cover this use case. If you have additional needs, please re-open the issue. 
The xml is actually invalid. Do you want the following one?
<derived it="dd">
<second>bla</second>
</derived>
I believe you can get what you want simply creating your own Converter:
public boolean canConvert(Class c)
{ return c.isAssignableFrom(base.class); }Therefore any extending class from base will get converted using this converter.
Does it solve your problem?