[XSTR-635] FieldDictionary's synchronized(this) usage has room for error.

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Not A Bug
Affects Version/s: 1.3.1
Fix Version/s: None
Component/s: Core
Labels:
None

Description

sync(this)

{ if missing in weakHashMap make it, and put it in }

// here
get from weakHashMap

The above has room for an item to disappear from the WeakHashMap between when it is checked for, and when it is retrieved. That said, it's a one in a billion chance.

Activity

Hide

Permalink

Jörg Schaible added a comment - 05/Nov/10 5:38 PM

Thanks for spotting this.

Show

Jörg Schaible added a comment - 05/Nov/10 5:38 PM Thanks for spotting this.

Hide

Permalink

Jörg Schaible added a comment - 15/Nov/10 8:10 PM

Actually this was not true. The type cannot disappear, since it is referenced as method parameter.

Show

Jörg Schaible added a comment - 15/Nov/10 8:10 PM Actually this was not true. The type cannot disappear, since it is referenced as method parameter.

People

Assignee:

Jörg Schaible

Reporter:

Paul Hammant

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

05/Nov/10 2:52 PM

Updated:

05/Aug/11 5:04 PM

Resolved:

15/Nov/10 8:10 PM