XStream
  1. XStream
  2. XSTR-555

AbstractStaxWriterTest.marshalWithBothRepairingModes only marshals with one repairing mode

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.4
    • Component/s: IO
    • Labels:
      None
    • JDK version and platform:
      OpenJDK 6 for Ubuntu Linux

      Description

      AbstractStaxWriterTest.marshalWithBothRepairingModes calls marshall, which purports to create a StaxWriter with repairing mode set to the value of a parameter. Unfortunately, when it actually creates the StaxWriter, it does so with a form of the constructor that does not specify the repairing mode, and that constructor simply calls another form of the constructor with repairing mode set to true.

      The attached patch fixes this problem by calling the appropriate constructor. You can see that it causes the existing tests to fail, at least with the Woodstox implementation, which is the only one I tried it with. I also added another test for an issue I've noticed where two elements with the same prefix in a row doesn't work the second time in non-repairing mode.

        People

        • Assignee:
          Jörg Schaible
          Reporter:
          Nathan Summers
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: