Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Won't Fix
-
Affects Version/s: 1.2.2
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
JDK version and platform:sun 1.5 for windows
Description
Serializing a class that has an array as an attrubute creates invalid JSON that wont reload into original Java class. It seems to misplace the } at the end of the array data in the generated JSON text, see below.
{"customer":{"ids":
{"string":["1","2","3","4"],"name":"david","postCode":"gu27 8uu"}}}
BTW if you use the default XML driver all works fine.
In the attached class if the ids attribute of the testCustomer class is the last attribute then all works fine if not it produces the following error :
Exception in thread "main" com.thoughtworks.xstream.converters.ConversionException: name : name
---- Debugging information ----
message : name : name
cause-exception : com.thoughtworks.xstream.mapper.CannotResolveClassException
cause-message : name : name
class : json.test.TestCustomer
required-type : [Ljava.lang.String;
path : /customer/ids/name
line number : -1
-------------------------------
at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:63)
at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:45)
at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:46)
at com.thoughtworks.xstream.annotations.AnnotationReflectionConverter.unmarshallField(AnnotationReflectionConverter.java:66)
at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doUnmarshal(AbstractReflectionConverter.java:188)
at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unmarshal(AbstractReflectionConverter.java:125)
at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:56)
at com.thoughtworks.xstream.core.AbstractReferenceUnmarshaller.convert(AbstractReferenceUnmarshaller.java:45)
at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:46)
at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:117)
at com.thoughtworks.xstream.core.ReferenceByXPathMarshallingStrategy.unmarshal(ReferenceByXPathMarshallingStrategy.java:29)
at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:846)
at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:833)
at com.thoughtworks.xstream.XStream.fromXML(XStream.java:781)
at com.thoughtworks.xstream.XStream.fromXML(XStream.java:773)
at json.test.Test.JSONToJava(Test.java:22)
at json.test.Test.main(Test.java:30)
Caused by: com.thoughtworks.xstream.mapper.CannotResolveClassException: name : name
at com.thoughtworks.xstream.mapper.DefaultMapper.realClass(DefaultMapper.java:49)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.ClassAliasingMapper.realClass(ClassAliasingMapper.java:76)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.DynamicProxyMapper.realClass(DynamicProxyMapper.java:60)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.ArrayMapper.realClass(ArrayMapper.java:76)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:26)
at com.thoughtworks.xstream.mapper.CachingMapper.realClass(CachingMapper.java:34)
at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.readItem(AbstractCollectionConverter.java:62)
at com.thoughtworks.xstream.converters.collections.ArrayConverter.unmarshal(ArrayConverter.java:44)
at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:56)
... 16 more
Issue Links
- depends upon
-
JETTISON-18
Classes with String array members are not serialized correctly
-
-
JETTISON-25
JSON output incorrect for List field
-
- is duplicated by
-
XSTR-454
Serializing objects to JSON by using JettisonMappedXmlDriver
-
Activity
Linking the appropriate issue at Jettison with XStream, since the same error manifests with arrays and especially since the patch for the Jettison code was posted to XStream's JIRA issue.
Jörg Schaible
added a comment - Linking the appropriate issue at Jettison with XStream, since the same error manifests with arrays and especially since the patch for the Jettison code was posted to XStream's JIRA issue. Applying this patch to 1.0-rc2 causes the unit tests (which seem correct) to fail.
The test tests for this :
{"root":{"child":[
,
{"subchild1":"test","subchild2":"test"},
{"subchild1":"test","subchild2":"test"},
{"subchild1":"test","subchild2":"test"}]
}}
Which seems correct (Right?). However, this patch creates :
{"root":{"child":[
,
{"subchild1":"test","subchild2":"test"},
"test","test"]},
"child":{"subchild1":"test","subchild2":"test"}}
Which is definitely not correct. Am I doing something wrong to test this?
Matt Reynolds
added a comment - Applying this patch to 1.0-rc2 causes the unit tests (which seem correct) to fail.
The test tests for this :
{"root":{"child":[
{"subchild1":"test","subchild2":"test"}
,
{"subchild1":"test","subchild2":"test"}
,
{"subchild1":"test","subchild2":"test"}
,
{"subchild1":"test","subchild2":"test"}
]
}}
Which seems correct (Right?). However, this patch creates :
{"root":{"child":[
{"subchild1":"test","subchild2":"test"}
,
{"subchild1":"test","subchild2":"test"}
,
"test","test"]},
"child":{"subchild1":"test","subchild2":"test"}}
Which is definitely not correct. Am I doing something wrong to test this? The problem is completely on Jettison's side. However, running HEAD of XStream with the HEAD of Jettison the attached test works, see output:
{"customer":{"ids":{"string":[1,2,3,4]},"name":"david","postCode":"gu27 8uu"}}
david
Since I do not know, when Jettison will be released the next time, all I can say that upcoming XStream will run with Jettison newer than 1.0-RC2 and this problem is solved.
Jörg Schaible
added a comment - The problem is completely on Jettison's side. However, running HEAD of XStream with the HEAD of Jettison the attached test works, see output:
{ "customer" :{ "ids" :{ "string" :[1,2,3,4]}, "name" : "david" , "postCode" : "gu27 8uu" }}
david
Since I do not know, when Jettison will be released the next time, all I can say that upcoming XStream will run with Jettison newer than 1.0-RC2 and this problem is solved. Closed after no further comment has been given.
Jörg Schaible
added a comment - Closed after no further comment has been given. 
I had this problem, and I patched with this
jettison/src/main/java/org/codehaus/jettison/mapped/MappedXMLStreamWriter.java (revision 39)
{ current = nodes.peek(); }+++ jettison/src/main/java/org/codehaus/jettison/mapped/MappedXMLStreamWriter.java (working copy)
@@ -180,9 +180,9 @@
if (current instanceof String)
else if (nodes.size() > 1 ) {
+ Object isArray = nodes.pop();
current = nodes.peek();
+ if (isArray instanceof JSONArray) { nodes.pop(); current = nodes.peek(); }