Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.2.2
-
Fix Version/s: 1.3.1
-
Component/s: Converters
-
Labels:None
Description
According to the api for CGLIBEnhancedConverter, this converter can only be used if "only one CAllback is registered". The code to check this condition is actually incorrect:
line 84:
if (callbacks.length > 1) {
it should be:
if (Arrays.asList(callbacks).size() > 1){
This makes the code break with Hibernate proxies, even though it shouldn't.
Issue Links
Activity
Any updates on this issue? my investigation brought me to the same conclusion, there are two
callbacks registered but one of them is a null, can't we simply ignore nulls?
Can't NoOp.class also be considered ignorable?
Any news on when we can expect this to be resolved?
Thanks,
Kaz-
Kasra Rasaee
added a comment - Any updates on this issue? my investigation brought me to the same conclusion, there are two
callbacks registered but one of them is a null, can't we simply ignore nulls?
Can't NoOp.class also be considered ignorable?
Any news on when we can expect this to be resolved?
Thanks,
Kaz- This also affects version 1.3
Frank Adcock
added a comment - This also affects version 1.3 I've just applied the change to my local version of xstream 1.2.2 which solves the problem for me. I've attached a patch in the hope of helping move this along. Cheers
Jerry Shea
added a comment - I've just applied the change to my local version of xstream 1.2.2 which solves the problem for me. I've attached a patch in the hope of helping move this along. Cheers CGLIB enhanced proxies with multiple callbacks are now supported if the proxy uses a factory (CGLIB default).
Jörg Schaible
added a comment - CGLIB enhanced proxies with multiple callbacks are now supported if the proxy uses a factory (CGLIB default). This is still a problem in 1.3.1. The fix is really simple: in getCallbacks(), just check that the callback's value is not null before adding it to the list to return. See attached patch (valid against 1.3.1 or trunk)
Jerry Shea
added a comment - This is still a problem in 1.3.1. The fix is really simple: in getCallbacks(), just check that the callback's value is not null before adding it to the list to return. See attached patch (valid against 1.3.1 or trunk) 
Sorry, but I don't see a difference. Why should the first condition break Hibernate proxies ?