Details
-
Type:
Bug
-
Status:
Closed
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.2.1
-
Component/s: None
-
Labels:None
Description
XStream xstream = new XStream(new JsonHierarchicalStreamDriver());
System.out.println(xstream.toXML("\"I'm in quotes\" is here"));
is messed up. (can't be parsed by JS) problem is JsonHierarchicalStreamWriter.writeText method doesnt handle quotes well.
Activity
In Java5 there is a handy String.replaceAll() method.... Thus JsonHierarchicalStreamWriter.writeText can be written simply as
private void writeText(String text, Class clazz) {
if (needsQuotes(clazz))
text = text.replaceAll("\"", "\\\\\"");
this.writer.write(text);
if (needsQuotes(clazz)) { writer.write("""); }
}
Show
Bob Herrmann
added a comment - In Java5 there is a handy String.replaceAll() method.... Thus JsonHierarchicalStreamWriter.writeText can be written simply as
private void writeText(String text, Class clazz) {
if (needsQuotes(clazz))
{
writer.write("\"");
}
text = text.replaceAll("\"", "\\\\\"");
this.writer.write(text);
if (needsQuotes(clazz)) {
writer.write(""");
}
}
Bob Herrmann
added a comment - In Java5 there is a handy String.replaceAll() method.... Thus JsonHierarchicalStreamWriter.writeText can be written simply as
private void writeText(String text, Class clazz) {
if (needsQuotes(clazz))
{
writer.write("\"");
}
text = text.replaceAll("\"", "\\\\\"");
this.writer.write(text);
if (needsQuotes(clazz)) {
writer.write(""");
}
} This does simply no longer compile on JDK 1.3 
Show
Jörg Schaible
added a comment - This does simply no longer compile on JDK 1.3
Jörg Schaible
added a comment - This does simply no longer compile on JDK 1.3 Fixed in Subversion. Please report if it works for you.
Show
Jörg Schaible
added a comment - Fixed in Subversion. Please report if it works for you.
Jörg Schaible
added a comment - Fixed in Subversion. Please report if it works for you. Closed as fixed for 1.2.1
Show
Jörg Schaible
added a comment - Closed as fixed for 1.2.1
Jörg Schaible
added a comment - Closed as fixed for 1.2.1 
Also try combinations like this;
String test1 = "\"I start with a quote";
String test2 = "I end with a quote\"";
String test3 = " middle \" has quote ";