Details
-
Type:
Bug
-
Status:
Closed
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.2
-
Component/s: None
-
Labels:None
-
JDK version and platform:1.5.0_02 for Macintosh
Description
Calling close() multiple times on an ObjectOutputStream created by calling XStream.createObjectOutputStream(...) results in an ArrayIndexOutOfBoundsException. It should detect that it has already been closed and ignore the call.
Here's a test case that can be put in XStreamTest.java:
public void testMultipleClose() {
try
catch( Exception ex )
{ ex.printStackTrace(); fail( ex.toString() ); }}
A patch for the fix is attached.
Activity
simpler patch (after reading StringWriter source code and comparing my patch to rob's...)
added behaviour:
1. close twice is ok + testcase
2. close and flush = stream exception + testcase
3. close and write = stream exception + testcase
should 2 and 3 ignore the call (as per rob?)?
flush could be ok as nothing changed
write would give the programmer the idea that the object was written but was actually ignored... probably dangerous.
4. added new streamexception constructor with simple string
Guilherme Silveira
added a comment - simpler patch (after reading StringWriter source code and comparing my patch to rob's...)
added behaviour:
1. close twice is ok + testcase
2. close and flush = stream exception + testcase
3. close and write = stream exception + testcase
should 2 and 3 ignore the call (as per rob?)?
flush could be ok as nothing changed
write would give the programmer the idea that the object was written but was actually ignored... probably dangerous.
4. added new streamexception constructor with simple string 1. corrected system tests 'catch' blocks
2. drop streamexception string constructor
3. only 'tries' the block where the exception is expected
Guilherme Silveira
added a comment - 1. corrected system tests 'catch' blocks
2. drop streamexception string constructor
3. only 'tries' the block where the exception is expected 
1. test case for two closes without any exception (thats the correct writer behaviour, check javadocs), test case for close+flush --> exception (same comment)
2. changed QuickWriter to be Writer-compliant (same comment)
3. kept PrettyWriter as XStream-compliant (StreamException)
4. kept CompactPrettyWriter as XStream-compliant (StreamException)