Details
-
Type:
New Feature
-
Status:
Closed
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.4
-
Component/s: None
-
Labels:None
Description
A converter/mapper for supporting hibernate collections.
Issue Links
Activity
Hi all,
Thanks all for this great solution !
I was playing around with this fix and I was having the classic hibernate exceptions telling there is no session attached any more.
The culprit was in HibernateCollectionConverterNEW.java when at the beginning of the marshal method, col.forceInitialization() is called.
I added a simple fix which will write null if the collection is null and won't call col.forceInitialization() is the session is null or not connected:
if (source instanceof AbstractPersistentCollection) {
AbstractPersistentCollection col = (AbstractPersistentCollection) source;
if ((col.getSession() != null) && col.getSession().isConnected())
collection = col.getStoredSnapshot();
} else if (source instanceof PersistentCollection)
if (collection == null)
{ NULL_CONVERTER.marshal(collection, writer, context); return; }...
nicolas lescure
added a comment - Hi all,
Thanks all for this great solution !
I was playing around with this fix and I was having the classic hibernate exceptions telling there is no session attached any more.
The culprit was in HibernateCollectionConverterNEW.java when at the beginning of the marshal method, col.forceInitialization() is called.
I added a simple fix which will write null if the collection is null and won't call col.forceInitialization() is the session is null or not connected:
if (source instanceof AbstractPersistentCollection) {
AbstractPersistentCollection col = (AbstractPersistentCollection) source;
if ((col.getSession() != null) && col.getSession().isConnected())
{
col.forceInitialization();
}
collection = col.getStoredSnapshot();
} else if (source instanceof PersistentCollection)
{
PersistentCollection col = (PersistentCollection) source;
col.forceInitialization();
// ToDo ES: collection = col.getCollectionSnapshot().getSnapshot();
collection = col.getStoredSnapshot();
}
if (collection == null)
{
NULL_CONVERTER.marshal(collection, writer, context);
return;
}
... xstream_hib.tar.gz (new version 29/Mar) is a tarball containing a maven/eclipse project bringing together some of the code people have been contributing to this issue, along with some minimal unit tests. The eclipse project is not a standalone alternative to maven - it relies on all the dependencies being in the maven repo.
This is intended to be a starting point so that future tweaks have a ready-made place to add unit tests. I have not come within light years of testing all of XStream's functionality in a Hibernate context, or within megaparsecs of testing all of Hibernate in an XStream context.
In particular:
I haven't addressed Jake's concerns about unflushed changes not being serialized.
I haven't done anything with LOB's (sorry Kevin).
I have included a test for Tim's aliasing concerns, but I removed a lot of Tim's changes because I didn't understand what they did and they weren't needed for that specific test.
I wasn't able to reproduce my own issues with the same object appearing in both proxied and unproxied form.
I haven't included Nicolas' code for serializing detached objects.
More background on the dev mailing list.
Jaime Metcher
added a comment - - edited xstream_hib.tar.gz (new version 29/Mar) is a tarball containing a maven/eclipse project bringing together some of the code people have been contributing to this issue, along with some minimal unit tests. The eclipse project is not a standalone alternative to maven - it relies on all the dependencies being in the maven repo.
This is intended to be a starting point so that future tweaks have a ready-made place to add unit tests. I have not come within light years of testing all of XStream's functionality in a Hibernate context, or within megaparsecs of testing all of Hibernate in an XStream context.
In particular:
I haven't addressed Jake's concerns about unflushed changes not being serialized.
I haven't done anything with LOB's (sorry Kevin).
I have included a test for Tim's aliasing concerns, but I removed a lot of Tim's changes because I didn't understand what they did and they weren't needed for that specific test.
I wasn't able to reproduce my own issues with the same object appearing in both proxied and unproxied form.
I haven't included Nicolas' code for serializing detached objects.
More background on the dev mailing list. Hi Jaime,
can you provide a version where the copyright in the sources is hold by the "XStream committers"? Simply add your name with an author tag to the classes instead.
Thanks!
Jörg Schaible
added a comment - Hi Jaime,
can you provide a version where the copyright in the sources is hold by the "XStream committers"? Simply add your name with an author tag to the classes instead.
Thanks! New version of xstream_hib.tar.gz with amended copyright notices
Jaime Metcher
added a comment - New version of xstream_hib.tar.gz with amended copyright notices Support is now in trunk in separate module. Thanks to all contributions and remarks.
Jörg Schaible
added a comment - Support is now in trunk in separate module. Thanks to all contributions and remarks. 
converter